Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide reset link #52808

Closed
kieferrm opened this issue Jun 25, 2018 · 3 comments
Closed

Hide reset link #52808

kieferrm opened this issue Jun 25, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Milestone

Comments

@kieferrm
Copy link
Member

Issue Type: Bug

We had discussed to remove the reset link and do the "right" thing and remove the actual entry in the settings.json when the actual value is the same as the default.

screen shot 2018-06-25 at 3 55 43 pm

VS Code version: Code - Insiders 1.25.0-insider (5d6156a, 2018-06-25T09:32:08.937Z)
OS version: Darwin x64 16.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz (8 x 2500)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (1.26GB free)
Process Argv /Users/kmaetzel/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_17449123
Screen Reader no
VM 0%
Extensions (24)
Extension Author (truncated) Version
solargraph cas 0.17.4
npm-intellisense chr 1.3.0
regex chr 0.2.0
githistory don 0.4.1
tslint eg2 1.0.33
vscode-npm-script eg2 0.3.4
vsc-material-theme Equ 2.1.0
git-project-manager fel 1.6.1
crazy kie 0.0.2
svgpreview kis 0.2.0
vscode-azurestorage ms- 0.3.1
mssql ms- 1.3.1
python ms- 2018.6.0
azure-account ms- 0.4.0
azurecli ms- 0.4.2
Go ms- 0.6.83
vsliveshare ms- 0.3.319
printcode nob 2.3.0
vscode-docker Pet 0.0.27
material-icon-theme PKi 3.5.0
Ruby reb 0.18.0
kustovscode sea 0.0.1
php-syntax-visualizer vsc 0.0.1
vscode-open-in-github ziy 1.3.3

(3 theme extensions excluded)

@kieferrm kieferrm added the settings-editor VS Code settings editor issues label Jun 25, 2018
@roblourens roblourens added this to the June 2018 milestone Jun 25, 2018
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Jun 25, 2018
@roblourens
Copy link
Member

It will be impossible to set a workspace setting to a default to override a user setting. But we can call that an "advanced" feature that they can use the JSON editor for.

@roblourens
Copy link
Member

And another option is to only 'reset' if the workspace setting's default value doesn't conflict with the current user setting's value, but I'd worry that would look inconsistent and confusing.

@roblourens
Copy link
Member

It's also not great for text fields.

Could apply @misolori's suggestion of showing the default value in the placeholder text for those.

@sandy081 sandy081 added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants