Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Linux product build #52819

Closed
joaomoreno opened this issue Jun 25, 2018 · 3 comments
Closed

Improve Linux product build #52819

joaomoreno opened this issue Jun 25, 2018 · 3 comments
Assignees
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. vscode-build VS Code build process issues
Milestone

Comments

@joaomoreno
Copy link
Member

We should maybe:

  1. Build and publish ZIP
  2. Build and publish DEB
  3. Build and publish RPM

Right now we're doing the following:

  1. Build ZIP, RPM, DEB
  2. Publish ZIP
  3. Publish DEB
  4. Publish RPM
@joaomoreno joaomoreno added debt Code quality issues vscode-build VS Code build process issues engineering VS Code - Build / issue tracking / etc. labels Jun 25, 2018
@joaomoreno joaomoreno added this to the July 2018 milestone Jun 25, 2018
@joaomoreno joaomoreno self-assigned this Jun 25, 2018
@joaomoreno
Copy link
Member Author

joaomoreno commented Jul 10, 2018

There's a current dependency between building the deb and the archive: the archive takes the version computed by the deb building for its public name...

@Tyriar Why do we have this version number in the archive again? Does it need to be (or should it even be) the same as the deb?

@Tyriar
Copy link
Member

Tyriar commented Jul 10, 2018

@joaomoreno the "revision number" (epoch timestamp) is used in the file names primarily to differentiate code_1.26.0_amd64.deb/zip/rpm from the following build in your downloads folder. However, for the deb package it is also used as the revision number for the package which defines the upgrade path; you can only upgrade from 1.26.0 to another 1.26.0 if the revision number is higher.

In an ideal world it would be the same for all the packages as you can use that to check the exact version, but it doesn't really matter (rpm is different I see). Feel free to give the zip and deb packages different numbers to make this easier.

@Tyriar
Copy link
Member

Tyriar commented Jul 14, 2018

Thanks @joaomoreno!

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. vscode-build VS Code build process issues
Projects
None yet
Development

No branches or pull requests

2 participants