Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declaring a SearchProvider breaks local search #52829

Closed
mfine15 opened this issue Jun 25, 2018 · 0 comments
Closed

Declaring a SearchProvider breaks local search #52829

mfine15 opened this issue Jun 25, 2018 · 0 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
June 2018

Comments

@mfine15
Copy link

mfine15 commented Jun 25, 2018

Testing #50497

  • VSCode Version: 1.25.0-Insiders
  • OS Version: Mac OS Sierra 10.13.3

Steps to Reproduce:

  1. Clone vscode-extension-samples
  2. Checkout roblou/searchProviderExample
  3. Launch fsprovider-sample
  4. Run F1 > [MemFS] Setup Workspace and F1 > [MemFs] Create Files
  5. Add a local folder to workspace
  6. Run Edit > Find in Files or Go > Go to file and verify that no results from local folder appear.

As far as I can tell, I don't think this is intended behavior. The SearchProvider is only registered for folders with the memfs scheme, so it seems to me that it shouldn't impact search for local folders with file:// scheme.

Does this issue occur when all extensions are disabled?: Yes
@vscodebot vscodebot bot added the search Search widget and operation issues label Jun 25, 2018
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Jun 25, 2018
@roblourens roblourens added this to the June 2018 milestone Jun 25, 2018
@mjbvz mjbvz added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
3 participants
@roblourens @mfine15 @mjbvz