WorkspaceEdit: create file - overwrite and ignoreExists can conflict

[isidorn]

Refs: #52800

Have an extension with the following WorkspaceEdit

workspaceEdit.createFile(vscode.Uri.file('c:\\Development\\Test\\hello2.txt'), {
            overwrite: true,
            ignoreIfExists: true
        });

Notice that those two settings are conflicting and it is nowhere specified that ignoreIfExists has priority - which is what I see in practice.

[jrieken]

Yeah, "make illegal states un-representable" they said...

[jrieken]

needs inspiration, moving to July since this is proposed only. Maybe remove ignoreIfExists...

[jrieken]

Yeah, I think we will just document this and overwrite will win

[isidorn]

@jrieken in your comment you say that "overwrite wins" however I was seeing that ignoreIfExists wins. Did you change some other behavior that now results in different behavior here.
Reopening just so you see my comment and moving to august

[jrieken]

Yeah, this was really implemented, not just a doc change. See https://github.com/Microsoft/vscode/blob/7289c303db9c6437489b08e558a83a11ff063438/extensions/vscode-api-tests/src/singlefolder-tests/workspace.test.ts#L712

[isidorn]

Verified it works as documented now