Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to manually update extension #52946

Closed
isidorn opened this issue Jun 26, 2018 · 2 comments
Closed

Failed to manually update extension #52946

isidorn opened this issue Jun 26, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 26, 2018

Refs: #52811

  1. Disable extension auto updates, Have some extension installed, open the package.json of that extension and modify its version to be lower
  2. Reload vscode, notice vscode properly offering to update the extension, click yes ->
  3. Failed to update error

If I try to uninstall the extension it no longer appears in the vscode ui, but it is left on disk. I would expect that VSCode is always able to remove the extension, even if a user manually modifies it

This happens for all extensions I have tried this process

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Jun 26, 2018
@sandy081 sandy081 added this to the June 2018 milestone Jun 26, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Jun 28, 2018

Hmm now if I change the package.json of an extension vscode complains that the extension has been modified on disk and that I should reload. IF I reload I no longer see the extension. I find this behavrior weird as the extension simply disapears beneth my feet -> reopening so we can discuss

@isidorn isidorn reopened this Jun 28, 2018
@sandy081
Copy link
Member

Looked at it with @isidorn and he has some previous state that uninstalled the particular version of the extension. Hence the extension disappeared when changed the version in the file.

With clean state everything looks ok. Hence closing.

@isidorn isidorn added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants