Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid: when opening a 2x2 grid existing editors are misplaced #52975

Closed
stevencl opened this issue Jun 26, 2018 · 2 comments
Closed

Grid: when opening a 2x2 grid existing editors are misplaced #52975

stevencl opened this issue Jun 26, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Milestone

Comments

@stevencl
Copy link
Member

stevencl commented Jun 26, 2018

Issue Type: Bug

Open two files side by side
View -> Editor Layout -> Grid 2x2
Note that the editor that was on the right hand side is now underneath the other editor.
Expected both editors to remain positioned side by side on the top row with two empty cells underneath each in the second row

This is made a little worse by the fact that when you then drag the editor from the bottom left to the top right, the group in the bottom left is closed.

VS Code version: Code - Insiders 1.25.0-insider (368ab9c, 2018-06-26T05:18:23.085Z)
OS version: Windows_NT x64 10.0.16299

System Info
Item Value
CPUs Intel(R) Core(TM) i7-3687U CPU @ 2.10GHz (4 x 2594)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: unavailable_software
webgl: enabled
webgl2: enabled
Memory (System) 7.89GB (1.08GB free)
Process Argv C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader no
VM 0%
Extensions (15)
Extension Author (truncated) Version
html-snippets abu 0.2.1
jshint dba 0.10.19
vscode-eslint dba 1.4.12
tslint eg2 1.0.33
vscode-great-icons emm 2.1.35
vscode-gutter-preview kis 0.12.2
vscode-azureappservice ms- 0.8.1
vscode-cosmosdb ms- 0.7.2
azure-account ms- 0.4.1
csharp ms- 1.15.2
vs-keybindings ms- 0.2.0
team ms- 1.136.0
debugger-for-chrome msj 4.7.0
addDocComments ste 0.0.8
cordova-tools vsm 1.4.0
![twofilestogrid2](https://user-images.githubusercontent.com/1704059/41917801-04d02b76-7953-11e8-9496-28e75cef60ae.gif)

Found while testing: #52334

@bpasero
Copy link
Member

bpasero commented Jun 26, 2018

This depends a little bit on the root orientation and might be hard to get right, but I am willing to look into this to see if there is something lowhanging we can do.

/cc @joaomoreno

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-editor-grid Grid layout issues in the editor area labels Jun 26, 2018
@bpasero bpasero added this to the June 2018 milestone Jun 26, 2018
@joaomoreno
Copy link
Member

@bpasero Maybe we can preserve the original orientation?

@joaomoreno joaomoreno added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

No branches or pull requests

3 participants