Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

onDidChangeActiveTerminal skips first terminal #53107

Closed
jrieken opened this issue Jun 27, 2018 · 1 comment
Closed

onDidChangeActiveTerminal skips first terminal #53107

jrieken opened this issue Jun 27, 2018 · 1 comment
Assignees
Labels
api bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jun 27, 2018

re #52834

  • have snippet like below
  • open 3 terminals via +, see three events
  • close/kill all terminals with the trash can
  • reopen terminal via ctrl+`
  • 馃悰 no event for the first terminal but events for subsequent terminals
'use strict';

import * as vscode from 'vscode';

export function activate (context: vscode.ExtensionContext) {

    function checkActiveTerminal () {
        let { activeTerminal } = vscode.window;
        console.log('activeTerminal: ' + (activeTerminal ? activeTerminal.name : '<none>'));
    }

    checkActiveTerminal();
    vscode.window.onDidChangeActiveTerminal(checkActiveTerminal);

    vscode.commands.registerCommand('extension.sayHello', async () => {
        //
    });
}
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Jun 27, 2018
@Tyriar Tyriar added this to the June 2018 milestone Jun 27, 2018
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug api labels Jun 27, 2018
@Tyriar Tyriar closed this as completed in dcc3bec Jun 27, 2018
@jrieken jrieken reopened this Jun 28, 2018
@jrieken jrieken closed this as completed Jun 28, 2018
@jrieken jrieken reopened this Jun 28, 2018
@jrieken
Copy link
Member Author

jrieken commented Jun 28, 2018

screen shot 2018-06-28 at 12 54 52

@Tyriar Tyriar closed this as completed in 7396416 Jun 28, 2018
@chrmarti chrmarti added the verified Verification succeeded label Jun 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants