Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter on Group header entry in TOC should expand or collapse #53125

Closed
sandy081 opened this issue Jun 27, 2018 · 3 comments
Closed

Enter on Group header entry in TOC should expand or collapse #53125

sandy081 opened this issue Jun 27, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

Testing #52859

When you press Enter / Click on a group header entry, it should expand/collapse.
When you click on an entry in the group, it should highlight the entry in the main content by preserving focus.
When you press Enter on an entry in the group, it should highlight and focus the entry in the main content.

This is similar to how our file explorer works and is user friendly

@roblourens
Copy link
Member

I think Enter should always send focus to the tree. Users can use arrow keys to expand/collapse. I think that's more typical because 'enter' doesn't work that way on Mac for any tree that I see.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Jun 28, 2018
@roblourens roblourens added this to the June 2018 milestone Jun 28, 2018
@roblourens
Copy link
Member

I implemented what I described, let me know what you think

@sandy081
Copy link
Member Author

Liked it.

@sandy081 sandy081 added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants