Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php] backtick commands not colorized correctly #532

Closed
splatonov92 opened this issue Nov 24, 2015 · 4 comments
Closed

[php] backtick commands not colorized correctly #532

splatonov92 opened this issue Nov 24, 2015 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues php PHP support issues
Milestone

Comments

@splatonov92
Copy link

Hello.
It is not comment, it is selection all files from the directory
screenshot from 2015-11-24 10 53 08

@aeschli
Copy link
Contributor

aeschli commented Nov 24, 2015

@splatonov92 Can you paste the problematic code here? Thanks a lot!

@splatonov92
Copy link
Author

if (isset ( $_POST ['type'] ) && $_POST ["type"] == "shlam") {
        info ( "{$pref} remove mudlog index files" );
        $result = `$runTS rm -rf var/MudlogProxy/* && echo "OK"`;
        isError ( $result, "remove var/MudlogProxy", "attempt to delete var/MudlogProxy" );
        if ($plugin == "GeologProxy.jar") {
            $result = `$runTS rm -f var/GeologProxy/cuttings.dat var/GeologProxy/calcimetry.dat var/GeologProxy/descriptions.dat var/GeologProxy/lithology.dat && echo "OK"`;
            isError ( $result, "remove var/GeologProxy", "attempt to delete var/GeologProxy" );
        }
    }

@aeschli aeschli changed the title Php/bash scripting error [php] backtick commands not colorized correctly Nov 24, 2015
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Nov 24, 2015
@egamma egamma added the languages-basic Basic language support issues label Nov 30, 2015
@aeschli aeschli added php PHP support issues and removed languages-basic Basic language support issues labels Nov 30, 2015
@kurtcorbett
Copy link

This is also a problem with double forward slash in js.

screen shot 2015-11-30 at 7 50 03 pm

  const contentObj = {
    domain: uriObj.host,
    path: uriObj.path,
    longUrl: `${uriObj.protocol}://${uriObj.host}${uriObj.path}`,
    type: '',
  };

@egamma egamma modified the milestone: Backlog Dec 10, 2015
@mjbvz mjbvz added the languages-basic Basic language support issues label Feb 1, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 1, 2017

@splatonov92 Just checked in VSCode 1.9 and it looks like the original issue has been fixed:

screen shot 2017-01-31 at 6 45 30 pm

@kurtcorbett This also is now fixed:

screen shot 2017-01-31 at 6 44 43 pm

@mjbvz mjbvz closed this as completed Feb 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues php PHP support issues
Projects
None yet
Development

No branches or pull requests

5 participants