Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERR File not found: package.json #53204

Closed
bpasero opened this issue Jun 28, 2018 · 3 comments
Closed

ERR File not found: package.json #53204

bpasero opened this issue Jun 28, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 28, 2018

Steps to Reproduce:

  1. open a folder without package.json
  2. check the console
ERR File not found (file:///Users/bpasero/Documents/ticino-playground/package.json): Error: File not found (file:///Users/bpasero/Documents/ticino-playground/package.json)
  at new FileOperationError (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/platform/files/common/files.js:201:32)
  at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/files/electron-browser/fileService.js:243:40
  at Object.notifyError [as _notify] (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1224:50)
  at Object.enter (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:916:30)
  at Promise_ctor._run (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1083:29)
  at Promise_ctor._error (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/winjs.base.js:1056:18)
  at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/async.js:677:135
  at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/node/extfs.js:37:32
  at /Users/bpasero/Development/Microsoft/monaco/node_modules/graceful-fs/polyfills.js:284:29
  at FSReqWrap.oncomplete (original-fs.js:114:15)

This seems to originate from workspaceStats.ts

@chrmarti
Copy link
Contributor

@ramya-rao-a Your recent change does not handle the mix of folders with package.json and without package.json.

@ramya-rao-a
Copy link
Contributor

Thanks @chrmarti

@ramya-rao-a ramya-rao-a added this to the June 2018 milestone Jun 28, 2018
@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Jun 28, 2018
@ramya-rao-a
Copy link
Contributor

To verify load a multi root setup where one folder has package.json file and another that doesn't.
The console shouldn't have the above errors

@bpasero bpasero added the verified Verification succeeded label Jun 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants