IUpdateService#isLatestVersion #53226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
approved these changes
Jun 28, 2018
| protected doQuitAndInstall(): void { | ||
| // noop | ||
| } | ||
|
|
||
| protected abstract setUpdateFeedUrl(quality: string): boolean; | ||
| protected abstract buildUpdateFeedUrl(quality: string): string; |
There was a problem hiding this comment.
Should it return string | undefined?
| try { | ||
| electron.autoUpdater.setFeedURL(createUpdateURL('darwin', quality)); | ||
| electron.autoUpdater.setFeedURL(url); |
There was a problem hiding this comment.
Not too happy that buildUpdateFeedUrl causes state to change in this service... but oh well
There was a problem hiding this comment.
not nice, but no bad side effects?
There was a problem hiding this comment.
On a second thought, it shouldn't behave different than before. The method is called as before, it just returns a string instead of a boolean... The name should maybe indicate the state-fullness but oh well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.