Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The IntelliSense gets triggered even in comments #538

Closed
hashhar opened this issue Nov 24, 2015 · 8 comments
Closed

The IntelliSense gets triggered even in comments #538

hashhar opened this issue Nov 24, 2015 · 8 comments
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@hashhar
Copy link
Contributor

hashhar commented Nov 24, 2015

This is both useful and bad depending on situations. But mostly undesirable. Maybe add a config value to control this as well?

@bpasero
Copy link
Member

bpasero commented Nov 24, 2015

Also really don't like it, @jrieken ping.

@jrieken
Copy link
Member

jrieken commented Nov 24, 2015

We currently don't know what a comment is. As soon as we know, we can make this change happen.

@jrieken jrieken added the feature-request Request for new features or functionality label Nov 24, 2015
@jrieken jrieken assigned jrieken and unassigned jrieken Nov 24, 2015
@hashhar
Copy link
Contributor Author

hashhar commented Nov 24, 2015

I think it could be done, as easy as checking if the current line has a comment opening character. And i believe you do know the comment characters because the ctrl +/ command inserts and removes it.

Or maybe not. Things sound very easy but writing it into code is difficult.

@jrieken
Copy link
Member

jrieken commented Nov 24, 2015

/*
sorry but will not work |<ctrl+space>
*/

We need to expose the scopes the tm-bundles define, it's on our plan but we are not there yet.

@hashhar
Copy link
Contributor Author

hashhar commented Nov 24, 2015

Great. Thanks for looking into it.
I believed the facilities for the languages supported out of the box was inbuilt.

@egamma egamma modified the milestone: Backlog Dec 10, 2015
@jrieken
Copy link
Member

jrieken commented Dec 22, 2015

We have made the default intellisense provider less aggressive. There is currently no plan to extract that in it's own plugin but when that happens user can decided to install or not. Not planning further work on this.

@jrieken jrieken closed this as completed Dec 22, 2015
@hashhar
Copy link
Contributor Author

hashhar commented Dec 22, 2015

I saw it. Works a lot better now and is more helpful. Thanks for looking into this.

@pspi
Copy link

pspi commented Dec 26, 2015

Reopen since it's not fixed?

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants