Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing log level doesnt affect the logs from the main process and issue reporter processes #54006

Closed
ramya-rao-a opened this issue Jul 11, 2018 · 4 comments
Closed

Changing log level doesnt affect the logs from the main process and issue reporter processes #54006

ramya-rao-a opened this issue Jul 11, 2018 · 4 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug log VS Code log issues verified Verification succeeded
Milestone
July 2018

Comments

@ramya-rao-a
Copy link
Contributor

  • Change the log level to trace
  • Notice that traces are now being printed to the output channel for shared and renderer process
  • Open a new folder (this should have triggered some traces in the main process)
  • The output channel for main process continues to use the default log level which is "info"
@vscodebot vscodebot bot added the log VS Code log issues label Jul 11, 2018
@ramya-rao-a ramya-rao-a mentioned this issue Jul 11, 2018
Merged
@ramya-rao-a ramya-rao-a changed the title Changing log level doesnt affect the logs from the main process Changing log level doesnt affect the logs from the main process and issue reporter processes Jul 11, 2018
@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Jul 11, 2018 •
edited

@joaomoreno @sandy081 This is because the main and issue reporter processes don't use the LogLevelSetterChannelClient.

@joaomoreno
Copy link
Member

@sandy081 I believe you had an issue to handle this?

@ramya-rao-a
Copy link
Contributor Author

Adding this to the current milestone as we need this fixed for the feature #54001 to be complete.

@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Jul 11, 2018
@ramya-rao-a ramya-rao-a added this to the July 2018 milestone Jul 11, 2018
@sandy081
Copy link
Member

Yeah, this should get propagate to all processes. Will check.

@joaomoreno joaomoreno removed their assignment Jul 12, 2018
@roblourens roblourens added the verified Verification succeeded label Aug 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug log VS Code log issues verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
4 participants
@joaomoreno @roblourens @sandy081 @ramya-rao-a