Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Focus search list command. Fixes #53696 #54196

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Add Focus search list command. Fixes #53696 #54196

merged 1 commit into from
Jul 13, 2018
+27 −1

Conversation

yogeshmangaj
Copy link

Adds "Search: Focus List" command to focus the Search results from the editor view.
Addressed #53696

@msftclas
Copy link

msftclas commented Jul 12, 2018 •
edited

CLA assistant check
All CLA requirements met.

@yogeshmangaj yogeshmangaj changed the title #53696 Add Focus search list command Add Focus search list command. Fixes #53696 Jul 12, 2018
@roblourens roblourens self-assigned this Jul 12, 2018
roblourens
roblourens requested changes Jul 13, 2018
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works when the search view is already open. I think you need to use openSearchView, not getSearchView.

@yogeshmangaj
Copy link
Author

@roblourens updated with openSearchView, manually tested it, opens the search panel if not open and then focuses it.

@roblourens
Copy link
Member

Thanks for the PR!

@roblourens roblourens added this to the July 2018 milestone Jul 13, 2018
@roblourens roblourens merged commit e89ed6e into microsoft:master Jul 13, 2018
@yogeshmangaj
Copy link
Author

@roblourens Thank you for helping me work on this, I look forward to doing more work on the project.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
July 2018
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yogeshmangaj @msftclas @roblourens