Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current symbol in breadcrumb dropdown is covered by find input box after reveal. #54444

Closed
rebornix opened this issue Jul 17, 2018 · 2 comments
Closed
Assignees
Milestone

Comments

@rebornix
Copy link
Member

rebornix commented Jul 17, 2018

Issue Type: Bug

  • Click on a symbol in the editor
  • Click on the last item in the breadcrumb
  • The symbol item in the treeview/dropdown is revealed and focused but seems it's covered by the input box.

breadcrumb-reveal

VS Code version: Code - Insiders 1.26.0-insider (6babef9, 2018-07-16T05:11:22.192Z)
OS version: Darwin x64 17.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.46GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_14798364
Screen Reader no
VM 0%
Extensions (42)
Extension Author (truncated) Version
spellright ban 2.5.16
markdown-emoji bie 0.0.7
solargraph cas 0.17.6
npm-intellisense chr 1.3.0
vscode-svgviewer css 1.4.4
vscode-markdownlint Dav 0.18.0
vscode-eslint dba 1.4.12
gitlens eam 8.5.0
remotehub eam 0.2.0
EditorConfig Edi 0.12.4
tslint eg2 1.0.33
vscode-npm-script eg2 0.3.5
vsc-material-theme Equ 2.3.0
ocaml hac 0.6.43
beautify Hoo 1.3.2
references-plusplus jri 0.0.5
vscode-pull-request-github Mic 0.0.3
dotenv mik 1.0.1
theme-monokai-pro-vscode mon 1.1.8
vscode-language-pack-zh-hans MS- 1.25.3
python ms- 2018.6.0
azure-account ms- 0.4.1
csharp ms- 1.15.2
Go ms- 0.6.84
PowerShell ms- 1.8.1
wordcount ms- 0.1.0
vsliveshare ms- 0.3.395
debugger-for-chrome msj 4.8.0
debugger-for-ios-web msj 0.1.2
color-highlight nau 2.3.0
vetur oct 0.12.5
vscode-versionlens pfl 0.21.1
material-icon-theme PKi 3.5.1
seti-icons qin 0.1.3
project-snippets reb 0.5.0
Ruby reb 0.18.0
smartpaste reb 0.0.3
toggle reb 0.0.1
sass-indented rob 1.4.9
rust rus 0.4.7
vscode-graphql stp 0.2.3
vscode-lldb vad 0.8.9

(7 theme extensions excluded)

@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Jul 17, 2018
@jrieken jrieken added breadcrumbs and removed editor editor-contrib Editor collection of extras labels Jul 17, 2018
@jrieken
Copy link
Member

jrieken commented Jul 17, 2018

@joaomoreno I call reveal, select, and focus but it doesn't seem to be properly revealed. See https://github.com/Microsoft/vscode/blob/379f5570229020c213ff11758c1b8dc629ee9e0a/src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts#L70. Ideas?

@jrieken jrieken added this to the July 2018 milestone Jul 17, 2018
@joaomoreno
Copy link
Member

You seem to be calling reveal before the tree was ever given a layout call.

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants