Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debug] launch.json validation shows warnings for extension debug adapters #546

Closed
daviwil opened this issue Nov 24, 2015 · 2 comments
Closed
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded

Comments

@daviwil
Copy link
Contributor

daviwil commented Nov 24, 2015

A user reported this on the vscode-powershell repo:

PowerShell/vscode-powershell#20

When a user opens their launch.json to debug PowerShell scripts using my extension's debug adapter, they get a warning stating that the type is not an accepted value:

image

There's also a warning which states that a property named "request" is missing. These warnings cause the user to think that their launch.json file is configured incorrectly even though the debugger launches successfully.

I suppose the validation just hasn't been updated yet to account for non-node debug adapters?

@isidorn
Copy link
Contributor

isidorn commented Nov 26, 2015

In the future we will make the "request" field required so that warning is correct. Using "request" we distinguish if we should launch or attach.

As for the type not being an accepted value I made a PR in your repo to fix that.

@isidorn isidorn closed this as completed Nov 26, 2015
@daviwil
Copy link
Contributor Author

daviwil commented Nov 26, 2015

Thanks for looking into this Isidor! Next time I'll check the docs to make sure I didn't do things wrong :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants