Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu is rendered outside the window, when there's still space for it #54630

Closed
joaomoreno opened this issue Jul 19, 2018 · 2 comments
Closed

Context menu is rendered outside the window, when there's still space for it #54630

joaomoreno opened this issue Jul 19, 2018 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
July 2018

Comments

@joaomoreno
Copy link
Member

Some math seems to be off when calculating the necessary space for that menu. Are you using the context view? If so, just leave this for me.

peek 2018-07-19 08-56
@sbatten
Copy link
Member

sbatten commented Jul 19, 2018

yes for context menus (not menubar menus) context view is being used.

@sbatten sbatten removed their assignment Jul 19, 2018
@sbatten sbatten mentioned this issue Jul 31, 2018
Closed
@joaomoreno joaomoreno added this to the July 2018 milestone Aug 2, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug workbench-contextview labels Aug 2, 2018
@joaomoreno joaomoreno mentioned this issue Aug 3, 2018
Closed
@joaomoreno joaomoreno changed the title Context menu forces workbench scroll Context menu is rendered outside the window, when there's still space for it Aug 3, 2018
@joaomoreno
Copy link
Member Author

Verifier: make sure that context menus (using custom UI on Windows or Linux) are always contained within the workbench.

@JacksonKearl JacksonKearl added the verified Verification succeeded label Aug 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
3 participants
@joaomoreno @sbatten @JacksonKearl