Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript settings do not disable TypeScript error messages in tooltips. #54692

Closed
dzrw opened this issue Jul 19, 2018 · 3 comments
Closed

TypeScript settings do not disable TypeScript error messages in tooltips. #54692

dzrw opened this issue Jul 19, 2018 · 3 comments
Assignees
Labels
typescript Typescript support issues

Comments

@dzrw
Copy link

dzrw commented Jul 19, 2018

If you are @mjbvz, please consider reading this bug report before closing the ticket with an irrelevant answer. The steps to reproduce take 60 seconds to complete.

We do not use TypeScript in several of our projects, so we have attempted to disable TypeScript validation in our JavaScript files. However, VSCode displays TypeScript-related messages despite the settings instructing it not to do so.

Apparently this is a regression in the latest build because there was another long bug closed by @sandy081 about a similar issue back in March 2018 where the team appeared to have communicated that the ability to disable TypeScript was a feature that VScode supported.

  • VSCode Version: 1.25.1
  • OS Version: macOS 10.13.6

Steps to Reproduce:

  1. Launch with code --disable-extensions
  2. Open User Settings and configure it as per below.
  3. Create a new file
  4. Type import test from "path"
  5. Change the Language Mode to "JavaScript"
  6. Hover over the word test and observe the message `[ts] 'test' is declared but its value is never read' appears inside the tooltip.
  7. The expected behavior is that VSCode does not attempt to communicate TypeScript-related error messages when TypeScript validation is disabled.

User Settings for Step 2

Important Clarification Default JavaScript settings should not be modified.

    # Surely one of these will turn off all [ts] messages in tooltips!
    "typescript.validate.enable": false,
    "typescript.autoImportSuggestions.enabled": false,
    "typescript.check.npmIsInstalled": false,
    "typescript.format.enable": false,
    "typescript.format.insertSpaceAfterCommaDelimiter": false,
    "typescript.format.insertSpaceAfterFunctionKeywordForAnonymousFunctions": false,
    "typescript.format.insertSpaceAfterKeywordsInControlFlowStatements": false,
    "typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": false,
    "typescript.format.insertSpaceAfterSemicolonInForStatements": false,
    "typescript.format.insertSpaceBeforeAndAfterBinaryOperators": false,
    "typescript.quickSuggestionsForPaths": false,
    "typescript.reportStyleChecksAsWarnings": false,
    "typescript.showUnused": false,
    "typescript.suggestionActions.enabled": false,
    "typescript.tsc.autoDetect": "off",
    "typescript.updateImportsOnFileMove.enabled": "never",
    "tslint.enable": false

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the typescript Typescript support issues label Jul 19, 2018
@vscodebot
Copy link

vscodebot bot commented Jul 19, 2018

@dzrw
Copy link
Author

dzrw commented Jul 19, 2018

Not a duplicate of #54691 because that was closed without the reviewer demonstrating that they understood the ticket.

@mjbvz
Copy link
Contributor

mjbvz commented Jul 19, 2018

Duplicate of #54691

Please post on original issue if you disagree with my response to it

@mjbvz mjbvz closed this as completed Jul 19, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

2 participants