Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White bar across top of titlebar mac #54838

Closed
lxsavage opened this issue Jul 23, 2018 · 10 comments · Fixed by #59742
Closed

White bar across top of titlebar mac #54838

lxsavage opened this issue Jul 23, 2018 · 10 comments · Fixed by #59742
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug mojave VS Code on OS X Mojave issues verified Verification succeeded
Milestone

Comments

@lxsavage
Copy link

Issue Type: Bug

Screen_Shot_2018-07-22_at_11.37.24_PM.png]

On MacOS Mojave, there is a white, horizontal bar that appears at the top of the software-generated title bar on the window.

Expected Result:

  • No white bar over top of titlebar

Actual Result:

  • White bar appears over top of titlebar

VS Code version: Code 1.25.1 (1dfc5e5, 2018-07-11T15:33:29.235Z)
OS version: Darwin x64 18.0.0

System Info
Item Value
CPUs Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz (4 x 3100)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 8.00GB (0.35GB free)
Process Argv /Applications/Visual Studio Code.app/Contents/MacOS/Electron
Screen Reader no
VM 0%
Extensions (9)
Extension Author (truncated) Version
npm-intellisense chr 1.3.0
tslint eg2 1.0.34
vscode-npm-script eg2 0.3.5
php-intellisense fel 2.3.3
code-runner for 0.9.3
beautify Hoo 1.3.2
applescript idl 0.10.0
python ms- 2018.7.0
csharp ms- 1.15.2

(1 theme extensions excluded)

@Tyriar Tyriar added the electron Issues and items related to Electron label Jul 23, 2018
@bpasero
Copy link
Member

bpasero commented Aug 6, 2018

@r2d2292 are you zoomed in in VSCode?

@bpasero bpasero added mojave VS Code on OS X Mojave issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Aug 6, 2018
@yoyo837
Copy link

yoyo837 commented Aug 22, 2018

Whether zoomed or not, it's the same.

@Augus
Copy link

Augus commented Sep 18, 2018

Is there any solution to this issue?

@roblourens
Copy link
Member

I see this on every window

@Tyriar
Copy link
Member

Tyriar commented Sep 25, 2018

@roblourens could you check another Electron 2 app (https://github.com/electron/electron-quick-start)?

@roblourens
Copy link
Member

Sorry I mean every window on MacOS. It's definitely just an annoying quirk of the dark theme.

@roblourens
Copy link
Member

roblourens commented Sep 25, 2018

Actually, it's not quite the same in other apps. I see the same issue on Chrome, Slack, OneNote, Teams, Atom, at least.

Not on Finder, Spotify, System Preferences, or apps with a native title bar.

@bpasero
Copy link
Member

bpasero commented Sep 25, 2018

This seems to be electron/electron#13164

@bpasero
Copy link
Member

bpasero commented Oct 1, 2018

Via #59742

@bpasero bpasero removed electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Oct 1, 2018
@miguelsolorio miguelsolorio added the verified Verification succeeded label Nov 1, 2018
@miguelsolorio
Copy link
Contributor

So this appears to add support for dark mode on Mojave. But now this adds a dark line for our light themes (bug?):

image

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug mojave VS Code on OS X Mojave issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants