Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate 'Add All Missing Imports' context menu entry #55065

Closed
chrmarti opened this issue Jul 25, 2018 · 4 comments
Closed

Duplicate 'Add All Missing Imports' context menu entry #55065

chrmarti opened this issue Jul 25, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues verified Verification succeeded
Milestone

Comments

@chrmarti
Copy link
Contributor

Issue Type: Bug

Testing #54861

In the VS Code repo:

  • Open extensionLinter.ts
  • Remove the Node as JsonNode import.
  • Change the one reference from JsonNode to Node.
  • Open context menu on error in Problems view

image

VS Code version: Code - Insiders 1.26.0-insider (5fae91d, 2018-07-25T01:56:56.548Z)
OS version: Darwin x64 17.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 4, 4
Memory (System) 16.00GB (0.20GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron
Screen Reader no
VM 22%
Extensions (21)
Extension Author (truncated) Version
regex chr 0.2.0
ssh chr 0.0.4
vscode-eslint dba 1.4.12
Spot der 0.4.0
ghlink dt 1.0.2
EditorConfig Edi 0.12.4
tslint eg2 1.0.34
rest-client hum 0.19.0
autofilename Jer 0.1.3
vscode-azureappservice ms- 0.9.0
vscode-azurefunctions ms- 0.10.0
vscode-cosmosdb ms- 0.8.0
azure-account ms- 0.4.2
azurecli ms- 0.4.2
github-issues-prs ms- 0.9.0
PowerShell ms- 1.8.1
debugger-for-chrome msj 4.8.2
vscode-docker Pet 0.0.27
vscode-versionlens pfl 0.21.1
vscode-open-in-github sys 1.7.0
azure-iot-toolkit vsc 1.1.0
@ghost
Copy link

ghost commented Jul 25, 2018

Simplified repro:
a.ts: export const foo = 0;
b.ts: export const foo = 0;
c.ts: foo; foo;
Hover over either foo in c.ts to see too many fixes.

@sandy081
Copy link
Member

@chrmarti Do you see the same when you show quick fixes in the editor?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Jul 25, 2018
@ghost
Copy link

ghost commented Jul 25, 2018

@sandy081 Yes.

@sandy081
Copy link
Member

@mjbvz Are you aware of this?

@mjbvz mjbvz assigned mjbvz and unassigned sandy081 Jul 25, 2018
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jul 25, 2018
@mjbvz mjbvz added this to the July 2018 milestone Jul 26, 2018
@mjbvz mjbvz added typescript Typescript support issues javascript JavaScript support issues labels Jul 26, 2018
@mjbvz mjbvz closed this as completed in 690744c Jul 26, 2018
@chrmarti chrmarti added the verified Verification succeeded label Aug 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants