Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextMate-derived themes should be able to affect colors of VS Code UI outside of the editor control #552

Closed
daviwil opened this issue Nov 24, 2015 · 3 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Milestone

Comments

@daviwil
Copy link
Contributor

daviwil commented Nov 24, 2015

It's cool how the in-box themes are able to change the colors of the UI surrounding the editor control. It would be really nice if there was a way for TextMate themes to affect the colors of this UI also.

One way to accomplish this would be to provide some new fields to the "theme" contribution in package.json which maps VS Code UI colors to specific keys in the TextMate definition. It would be up to the author of the theme package to choose which keys/colors to use for the UI element colors. This would allow the theme author to be able to write the color codes in the theme file without having to update their package.json.

@jrieken jrieken added the feature-request Request for new features or functionality label Nov 24, 2015
@egamma egamma modified the milestone: Backlog Dec 10, 2015
@satya164
Copy link

+1

1 similar comment
@rojorojo
Copy link

rojorojo commented Feb 3, 2016

+1

@bpasero
Copy link
Member

bpasero commented Jan 19, 2017

#3112

@bpasero bpasero closed this as completed Jan 19, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 19, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants