Disable snippets in extension search (when not in suggest dropdown) #55281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzec
approved these changes
Jul 28, 2018
ramya-rao-a
reviewed
Jul 28, 2018
| @@ -342,7 +343,7 @@ export class ExtensionsViewlet extends ViewContainerViewlet implements IExtensio | |||
| this.monacoStyleContainer = append(header, $('.monaco-container')); | |||
| this.searchBox = this.instantiationService.createInstance(CodeEditorWidget, this.monacoStyleContainer, | |||
| mixinHTMLInputStyleOptions(getSimpleEditorOptions(), localize('searchExtensions', "Search Extensions in Marketplace")), | |||
| getSimpleCodeEditorWidgetOptions()); | |||
| { isSimpleWidget: true, contributions: [SuggestController] }); | |||
There was a problem hiding this comment.
I agree we don't need SnippetController2 and TabCompletionController, but have you gone through what the other contributions (MenuPreventer, SelectionClipboard, ContextMenuController) of the simple editor have to offer to ensure we are not missing out on anything?
There was a problem hiding this comment.
MenuPreventerstopsAlt+clickfrom toggling the menu bar visibility. We should have that.SelectionClipboardis a Linux specific thing that I can't seem to get to trigger on Windows. From what I can tell, it automatically adds whatever you select to your clipboard and pastes it on middle click. Not sure if this is something we want, given we select the search text for the user occasionally and this might overwrite their clipboardContextMenuControllerallows you to right click in the search box. We should have that.
|
Looks like removing SnippetController2 is breaking the ability to insert text. Error shows up: |
|
Looks like the SuggestController delegates the actual insertion of text to the SnippetController2. So removing SnippetController2 breaks the SuggestContoller. Not sure what the best way to proceed from here is...
|
JacksonKearl
force-pushed
the
disable-snippits-in-extensions-search
branch
from
8494f50
to
b0af12c
Compare
|
Needed for #55386. |
ramya-rao-a
approved these changes
Jul 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #55278, but a full solution is contingent on #55280.
This closes #55280 with 5a32484