Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPC could behave incorrectly for some message types #55335

Closed
attilah opened this issue Jul 29, 2018 · 2 comments
Closed

IPC could behave incorrectly for some message types #55335

attilah opened this issue Jul 29, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@attilah
Copy link

attilah commented Jul 29, 2018

While I reading through the source code I found this possible problem:

https://github.com/Microsoft/vscode/blob/master/src/vs/base/parts/ipc/common/ipc.ts#L27

And this function used in the onMessage method and can cause an immediate return for RequestEventListen``, RequestEventDisposemessages based on theMessageType``` enum at the top.

I found no use case in the code where it should fail, but IMHO the isResponse method implementation is not correct and can cause future hard to catch problems.

@joaomoreno
Copy link
Member

Oh man that's BAD. Great eye!

@joaomoreno joaomoreno added this to the July 2018 milestone Aug 2, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug ipc labels Aug 2, 2018
@joaomoreno
Copy link
Member

Verifier: please code review.

@aeschli aeschli added the verified Verification succeeded label Aug 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants