Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings editor scrollbar should be along far right edge #55795

Closed
roblourens opened this issue Aug 3, 2018 · 5 comments
Closed

Settings editor scrollbar should be along far right edge #55795

roblourens opened this issue Aug 3, 2018 · 5 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
September 2018

Comments

@roblourens
Copy link
Member

It used to be like that but the layout got more complicated.
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Aug 3, 2018
@roblourens roblourens added this to the August 2018 milestone Aug 3, 2018
@roblourens roblourens self-assigned this Aug 3, 2018
This was referenced Aug 3, 2018
Closed
Closed
@itamark
Copy link
Contributor

itamark commented Aug 10, 2018 •
edited

@roblourens I think I figured out a decent solution. It'll be ready likely today.

@roblourens
Copy link
Member Author

Awesome :)

@itamark
Copy link
Contributor

itamark commented Aug 10, 2018

@roblourens Okay I have the scrollbar stuck to the right and with the right top justification.
Problem is that the settings themselves still have a max width of 1000px - so the space between the settings and the scrollbar is not scrollable. Is that ok?
scroll

@itamark itamark mentioned this issue Aug 10, 2018
Closed
@roblourens
Copy link
Member Author

Well having that space scrollable is a big part of my motivation for doing this. Sorry that the original issue didn't spell that out, but I want to change the layout so that the scrollable area includes that whole margin.

@itamark
Copy link
Contributor

itamark commented Aug 11, 2018

@roblourens There - I added another commit that seems to solve this completely.

@bpasero bpasero added the verified Verification succeeded label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
3 participants
@roblourens @bpasero @itamark