Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back the old menu due to electron 2.0 issues #55913

Merged
merged 2 commits into from Aug 7, 2018
Merged

Bring back the old menu due to electron 2.0 issues #55913

merged 2 commits into from Aug 7, 2018

Conversation

sbatten
Copy link
Member

@sbatten sbatten commented Aug 6, 2018

When using native, we should use the old menu for this release while we sort out Electron issues

@sbatten sbatten self-assigned this Aug 6, 2018
@bpasero bpasero added this to the July 2018 milestone Aug 7, 2018
bpasero
bpasero approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comparing the menus (on macOS at least), I see subtle difference in the Debug menu (additional separator for breakpoints) and the View menu (missing entry to "Toggle Menu Bar" in our custom menu solution):

image

image

Maybe @Tyriar could verify on Linux and @rebornix on Windows

Tyriar
Tyriar approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Linux another more subtle difference; there's no separator between File > Auto Save and Preferences on Insiders but there is in this PR

@sbatten sbatten merged commit 92521b2 into master Aug 7, 2018
sbatten added a commit that referenced this pull request Aug 7, 2018
@sbatten
Bring back the old menu due to electron 2.0 issues (#55913)
18d0027 
* add the old menu back for native menus

* make menu labels match
This was referenced Aug 7, 2018
Closed
Closed
@sbatten sbatten deleted the sbatten/returnToOldMenu branch August 7, 2018 18:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

@bpasero bpasero bpasero approved these changes

@Tyriar Tyriar Tyriar approved these changes

Assignees

@sbatten sbatten

Labels
None yet
Projects
None yet
Milestone
July 2018
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sbatten @rebornix @bpasero @Tyriar