Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git: reverting changes for deleted file shows unclear error #55915

Closed
JacksonKearl opened this issue Aug 6, 2018 · 1 comment · Fixed by #55975
Closed

Git: reverting changes for deleted file shows unclear error #55915

JacksonKearl opened this issue Aug 6, 2018 · 1 comment · Fixed by #55975
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Milestone
September 2018

Comments

@JacksonKearl
Copy link
Contributor

Delete a file. Attempt to undo the deletion. See error message:
image

This could stand to be more clear. It makes sense on the technical side, but some git novices might be confused. I personally had to double check I was reverting the right change.
@vscodebot vscodebot bot added the git GIT issues label Aug 6, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Aug 7, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Aug 7, 2018
@wistcc wistcc mentioned this issue Aug 8, 2018
Merged
@donaldnevermore
Copy link
Contributor

donaldnevermore commented Aug 19, 2018 •
edited
Loading

I think changing the message to Are you sure you want to restore the deleted file {0}? is ok when discarding the changes in a deleted file.

@joaomoreno joaomoreno modified the milestones: Backlog, September 2018 Sep 12, 2018
@octref octref added the verified Verification succeeded label Sep 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

Successfully merging a pull request may close this issue.

Fixing text when reverting changes for deleted file wistcc/vscode
4 participants
@joaomoreno @octref @JacksonKearl @donaldnevermore