Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image files of *.tiff format do not display properly #55987

Closed
deadcoder0904 opened this issue Aug 8, 2018 · 3 comments
Closed

Image files of *.tiff format do not display properly #55987

deadcoder0904 opened this issue Aug 8, 2018 · 3 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2018

Comments

@deadcoder0904
Copy link

Issue Type: Feature Request

Just like it opens up png files, support tiff as well :)

VS Code version: Code 1.25.1 (1dfc5e5, 2018-07-11T15:33:29.235Z)
OS version: Darwin x64 17.7.0
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Aug 8, 2018
@bpasero
Copy link
Member

bpasero commented Aug 8, 2018

@mjbvz I can open a tiff file but it does not show properly. Could this be related to the inlining we seem to do?

@bpasero bpasero changed the title Support tiff extension for Image Preview Image files of *.tiff format do not display properly Aug 8, 2018
@mjbvz mjbvz added this to the August 2018 milestone Aug 24, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Aug 24, 2018 •
edited

Chrome—and therefore electron—does not support displaying tiffs. We should treat tiffs as binary files instead of trying to open them as images

@mjbvz mjbvz closed this as completed in bd6bd5f Aug 24, 2018
@deadcoder0904
Copy link
Author

Cool. Bdw you peeps are doing a wonderful job. Probably the best team for me ❤️

@bpasero bpasero added the verified Verification succeeded label Aug 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2018
Development

No branches or pull requests
3 participants
@bpasero @mjbvz @deadcoder0904