Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show recommended with popular when no extensions installed #56186

Merged
merged 2 commits into from
Aug 13, 2018

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Aug 11, 2018

Related to #56042

This PR covers the following

  • Remove dedicated view for installed extensions. This is not needed anymore as we have moved on to show enabled/disabled sections in the default extensions view instead of installed.
  • When there are no installed extensions, show recommended section along with the popular one.

@ramya-rao-a ramya-rao-a self-assigned this Aug 11, 2018
@ramya-rao-a ramya-rao-a changed the title Separate view for Installed not needed as we show enabled, disabled by default Show recommended with popular when no extensions installed Aug 11, 2018
@sandy081
Copy link
Member

LGTM

@ramya-rao-a ramya-rao-a merged commit 5e5f6fc into master Aug 13, 2018
@ramya-rao-a ramya-rao-a deleted the ramyar/installed branch August 13, 2018 17:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants