Debt: avoid promise.cancel in zip.ts #56656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
jrieken
reviewed
Aug 17, 2018
| const throttler = new SimpleThrottler(); | ||
| return createCancelablePromise(token => { | ||
|
|
||
| once(token.onCancellationRequested)(() => { |
There was a problem hiding this comment.
No once not needed as the event will only ever fire once
sandy081
reviewed
Aug 20, 2018
| } | ||
|
|
||
| if (!options.sourcePathRegex.test(entry.fileName)) { | ||
| readNextEntry(); |
There was a problem hiding this comment.
Why are we not passing the real token instead of none token?
sandy081
reviewed
Aug 20, 2018
src/vs/base/node/zip.ts
Outdated
| } | ||
|
|
||
| if (!options.sourcePathRegex.test(entry.fileName)) { | ||
| readNextEntry(CancellationToken.None); |
There was a problem hiding this comment.
Why are we not passing the real token instead of none token?
There was a problem hiding this comment.
Good catch, I guess I added this first and only later added the token.
|
@sandy081 can you check again, I also removed |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #56137
@sandy081 adding you because this area is sensitive for extracting extensions. I converted the code to use
CancellationTokenand avoidTPromise.cancel()./cc @jrieken