Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the color of the window-appicon in custom window titlebar customizable #56857

Closed
yuval-gilboa opened this issue Aug 20, 2018 · 5 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code titlebar VS Code main title bar issues
Milestone

Comments

@yuval-gilboa
Copy link

This is a feature request for customizing the window-appicon in the custom workbench titlebar. The SVG image for the appicon should be defined using fill: currentColor so it inherits the foreground color of the titlebar, or better yet, add a special color entry for it in the workbench color customizations section.

This would allow adjusting the appicon appearance to custom titlebar backgrounds and avoid contrast issues like below:

image

@vscodebot
Copy link

vscodebot bot commented Aug 20, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@miguelsolorio
Copy link
Contributor

We could look at providing the option to use either the default icon or the foreground color (which is what the title bar text uses). This can get a little tricky as we currently use the icon to show what version of VS Code is being used (blue = stable, green = insiders).

@sbatten, thoughts?

@miguelsolorio miguelsolorio added the under-discussion Issue is under discussion for relevance, priority, approach label Aug 22, 2018
@sbatten
Copy link
Member

sbatten commented Aug 23, 2018

@misolori I'm not opposed to making the icon themable to the extent of using the foreground color. Just want to make sure that's something that fits in our guidelines.

@sbatten sbatten added titlebar VS Code main title bar issues feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Sep 10, 2018
@sbatten sbatten added this to the On Deck milestone Sep 10, 2018
@miguelsolorio
Copy link
Contributor

This goes against our branding guidelines since we only ever use Blue (Stable), Green (Insiders), Orange (Explorations), Black/White when needed. So will be closing this as out of scope.

@miguelsolorio miguelsolorio added the *out-of-scope Posted issue is not in scope of VS Code label Oct 8, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 8, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code titlebar VS Code main title bar issues
Projects
None yet
Development

No branches or pull requests

3 participants