Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrated terminal - powershell command colors with light theme #56985

Closed
jeffrson opened this issue Aug 22, 2018 · 3 comments
Closed

integrated terminal - powershell command colors with light theme #56985

jeffrson opened this issue Aug 22, 2018 · 3 comments
Assignees
Labels
*as-designed Described behavior is as designed terminal Integrated terminal issues

Comments

@jeffrson
Copy link

The default input color (of type command) in PowerShell is yellow. Obviously this is unreadable inside the integrated terminal when using a light theme.

The color may be changed by

Set-PSReadlineOption -TokenKind Command -ForegroundColor Black

however, this does not yield the expected result: Commands seem to be "hidden" (invisible, indeed). Instead, with

Set-PSReadlineOption -TokenKind Command -ForegroundColor White

the typed command is shown as (somewhat bold!) black.

So it seems white and black are (kind of) reversed.

While blue and green are not correct as well (in some themes), this may depend on the actual theme. However, black and white are wrong in lots of light themes, so I would assume it's a bug. Sorry if I'm wrong...

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Aug 22, 2018
@Tyriar
Copy link
Member

Tyriar commented Aug 22, 2018

I think this is as designed as AFAIK it's the default for powershell (was it not designed to ever show on a light terminal?) and themes are meant to provide enough contrast to make out yellow on white.

/cc @tylerl0706

@Tyriar Tyriar closed this as completed Aug 22, 2018
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Aug 22, 2018
@TylerLeonhardt
Copy link
Member

Here's the issue you're looking for:

PowerShell/PSReadLine#464

@jeffrson
Copy link
Author

The real problem for me wasn't the yellow characters, but instead that White is bold black, and Black is invisible. But DarkGray is dark gray (what I'm using now).

Nevertheless, that PSReadline related discussion is interesting - for some reason I had only looked for issues in PowerShell archives.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

3 participants