Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GDPR annotation for typescript-language-features/languageserviceerrorresponse #57182

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Aug 24, 2018

I'm not sure how to validate the comment itself, but I believe the classifications are correct.

"languageServiceErrorResponse" : {
"command" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"message" : { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
"stack" : { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the stack will include paths if a user is using the workspace version of typescript

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the classification "CallstackOrException" covers that.

@mjbvz mjbvz added this to the September 2018 milestone Sep 4, 2018
@mjbvz mjbvz merged commit cd7c7c5 into microsoft:master Sep 4, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants