Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

title bar is not hidden even when zen mode in case of titleBarStyle = custom and menuBarVisibility = toggle #57278

Closed
mizutoki79 opened this issue Aug 27, 2018 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@mizutoki79
Copy link

mizutoki79 commented Aug 27, 2018

  • VSCode Version: 1.26.1
  • OS Version: Windows 10 Pro 1803

Steps to Reproduce:

  1. set below config
"window.menuBarVisibility": "toggle",
"window.titleBarStyle": "custom"
  1. start zen mode

Does this issue occur when all extensions are disabled?: Yes

specification

all default settings
default

only custom title bar
customtitle

[bug] custom title bar and menu bar is toggle
customtitleandtogglemenu

#56293 mentioned only in full screen, but I mention in zen mode
#44593 said "So only if tabs are not shown we hide the title area. ZenMode by default hidesTabs so I think it will behave nicely", but I mention even if hidesTabs

@mizutoki79 mizutoki79 changed the title title bar is not hidden even when zen mode in case of title title bar is not hidden even when zen mode in case of titleBarStyle = custom Aug 27, 2018
@mizutoki79
Copy link
Author

it seems that this issue is duplicate of #56127.
sorry. thank you.

@mizutoki79 mizutoki79 changed the title title bar is not hidden even when zen mode in case of titleBarStyle = custom title bar is not hidden even when zen mode in case of titleBarStyle = custom and menuBarVisibility = toggle Aug 27, 2018
@sbatten sbatten closed this as completed Aug 28, 2018
@sbatten sbatten added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants