Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test settings editor #57304

Closed
3 tasks done
roblourens opened this issue Aug 28, 2018 · 2 comments
Closed
3 tasks done

Test settings editor #57304

roblourens opened this issue Aug 28, 2018 · 2 comments

Comments

@roblourens
Copy link
Member

roblourens commented Aug 28, 2018

Testing #55791

Complexity: 4

Test everything in the settings editor. Note that there are screen reader fixes still incoming.

Test combinations of @filter, search, and clicking on the TOC to filter during search. Test that editing settings works while searching and filtering.

Test that you can open multiple instances of the settings editor, and they don't get out of sync.

Test that you can navigate by keyboard in a sane way.

Test that the new setting to pick your preferred settings editor, workbench.settings.editor, works, and it applies to all the different ways to open settings (default keybinding, menu, activity bar, search viewlet, maybe others)

The settings editor loads pages of settings as you scroll. You can see the scrollbar jerk as you scroll to the end. Watch for any issues this might cause.

Test the gear icon context menu. Default keybinding is shift+f9.

Test editing in different scopes in multi and single folder workspaces, and empty windows. Test that you only see settings that are valid for the scope.

Test that the new dropdown control is a good experience and works the way a dropdown control should, and that enumDescriptions are shown and rendered as markdown when they should be.

Watch for descriptions or enumDescriptions that are not rendered as markdown when they should be (setting contributions now have to opt in to be rendered as markdown, and I had to manually find all descriptions that use markdown)

@roblourens roblourens added this to the August 2018 milestone Aug 28, 2018
@isidorn
Copy link
Contributor

isidorn commented Aug 28, 2018

@roblourens since you mention that screen reader fixes are incoming I did not test nvda support. Let me know once those land and I can re-test that.

@roblourens
Copy link
Member Author

Total carnage 😆 thanks for the testing everyone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants