Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript] Cancel geterr before any user-invoked operation #57542

Closed
amcasey opened this issue Aug 29, 2018 · 3 comments
Closed

[TypeScript] Cancel geterr before any user-invoked operation #57542

amcasey opened this issue Aug 29, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues verified Verification succeeded

Comments

@amcasey
Copy link
Member

amcasey commented Aug 29, 2018

i.e. Extend 558635a from change to requests like completionInfo and completionEntryDetails.

The corresponding TS issue is microsoft/TypeScript#19458.

@vscodebot vscodebot bot added the typescript Typescript support issues label Aug 29, 2018
@ahejlsberg
Copy link
Member

FWIW, this issue is really pronounced when you're editing in large files, like src/compiler/checker.ts in the TypeScript repro--which I so happen to do a lot! Statement completion will often take as much as five seconds to show up because TSServer is busy computing an error list that will just be discarded anyway.

I'd really appreciate getting this fixed.

@kieferrm kieferrm added this to the September 2018 milestone Aug 30, 2018
@mjbvz mjbvz closed this as completed in a9e93b1 Sep 5, 2018
@mjbvz mjbvz mentioned this issue Sep 19, 2018
4 tasks
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Sep 24, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Sep 27, 2018

To verify:

  1. git clone https://github.com/Microsoft/TypeScript.git
  2. Open typescript as folder in vscode. Then open the src/compiler/checker.ts file
  3. Wait for initial loading of js/ts language features
  4. Type something that will produce an error then trigger suggestions
  5. Suggestions should be shown relatively quickly

@isidorn isidorn added the verified Verification succeeded label Sep 28, 2018
@isidorn
Copy link
Contributor

isidorn commented Sep 28, 2018

Suggestions are shown after 0.5s, I take that as realtivly quickly considering the size of the file -> verified

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants