Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer breaker: vs/base/node/zip cannot depend on vs/platform #57790

Closed
bpasero opened this issue Sep 3, 2018 · 0 comments
Closed

Layer breaker: vs/base/node/zip cannot depend on vs/platform #57790

bpasero opened this issue Sep 3, 2018 · 0 comments
Assignees
Labels
debt Code quality issues

Comments

@bpasero
Copy link
Member

bpasero commented Sep 3, 2018

It looks like vs/base/node/zip.ts depends on vs/platform/logservice. That violates our rules for layering.

@bpasero bpasero added the debt Code quality issues label Sep 3, 2018
@sandy081 sandy081 added this to the September 2018 milestone Sep 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

2 participants