Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_tryExtHostHandshake depends on winjs.promise timing #57820

Closed
jrieken opened this issue Sep 3, 2018 · 3 comments
Closed

_tryExtHostHandshake depends on winjs.promise timing #57820

jrieken opened this issue Sep 3, 2018 · 3 comments
Assignees
Labels
debt Code quality issues

Comments

@jrieken
Copy link
Member

jrieken commented Sep 3, 2018

This commit 7224bb3 apparently broken debug in weird ways. The $registerDebugTypes was called anymore. This commit fixed it again:
407a485

@jrieken jrieken added this to the September 2018 milestone Sep 3, 2018
@jrieken jrieken added the debt Code quality issues label Sep 3, 2018
@jrieken jrieken self-assigned this Sep 3, 2018
@alexdima
Copy link
Member

alexdima commented Sep 3, 2018

How can that break debugging 🦀

@jrieken
Copy link
Member Author

jrieken commented Sep 4, 2018

Good question... I was in revert mode only but my theory is that it sends a message before we are ready for it to be processed (it sends something in a ctor-call).

@alexdima
Copy link
Member

alexdima commented Sep 5, 2018

After some investigation: this is not about the ctor.

TPromise and Promise behave in the same way around the invocation order of the ctor.

The difference is the invocation of then, where Promise always invokes then on the next tick. The result of the promise is an IMessagePassingProtocol and in between those ticks to invoke the then handler, a message (or more) get lost.

I will look into how it would be possible to refactor this... It would almost need pause/resume functionality on IMessagePassingProtocol...

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

2 participants