Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't blink "No results" between local and remote settings search results #58035

Closed
roblourens opened this issue Sep 6, 2018 · 3 comments
Closed

Don't blink "No results" between local and remote settings search results #58035

roblourens opened this issue Sep 6, 2018 · 3 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
November 2018

Comments

@roblourens
Copy link
Member

  • In settings, search query that will return remote results but not local results
  • See 'no results' briefly appear before remote results are loaded

Don't show 'no results' at that point...
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Sep 6, 2018
@roblourens roblourens self-assigned this Sep 6, 2018
@roblourens roblourens added this to the September 2018 milestone Sep 6, 2018
@roblourens roblourens mentioned this issue Sep 6, 2018
Closed
@itamark
Copy link
Contributor

itamark commented Sep 17, 2018

@roblourens would love to try to solve this one as well if that's ok.

@roblourens
Copy link
Member Author

Sure

@itamark
Copy link
Contributor

itamark commented Sep 20, 2018 •
edited

Nevermind - I can't reproduce this either. The blink isn't happening and I'm not sure how to force a longer remote fetch.
From now on I'll make sure to try to reproduce before volunteering 😬

@RMacfarlane RMacfarlane added the verified Verification succeeded label Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
3 participants
@roblourens @itamark @RMacfarlane