Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all keybindings hints ported in custom titleBar #58186

Closed
usernamehw opened this issue Sep 7, 2018 · 2 comments
Closed

Not all keybindings hints ported in custom titleBar #58186

usernamehw opened this issue Sep 7, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@usernamehw
Copy link
Contributor

Issue Type: Bug

"window.titleBarStyle": "custom"

Activity bar context menu
activity_bar_context_menu

Hide sidebar
hide_sidebar

Context menu for open editors
context_menu_open_editors

Copy error for problems panel context menu
copy_on_error_context_menu

Terminal context menu
terminal_context_menu

Hide panel for panel context menu
hide_panel

Almost all inputs context menu
inputs_context_menu

Keybindings GUI context menu
keybindings_context_menu

VS Code version: Code - Insiders 1.28.0-insider (a3f9f2e, 2018-09-07T05:20:29.346Z)
OS version: Windows_NT x64 10.0.17134

@vscodebot vscodebot bot added the insiders label Sep 7, 2018
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug workbench-menu labels Sep 7, 2018
@sbatten sbatten added this to the On Deck milestone Sep 7, 2018
@bpasero bpasero self-assigned this Sep 17, 2018
@bpasero bpasero modified the milestones: On Deck, September 2018 Sep 17, 2018
@bpasero
Copy link
Member

bpasero commented Sep 17, 2018

@sbatten fyi went ahead and fixed it because I was not happy with how the native context menu service differs here to the custom one (where I guess I fixed it a while ago). Turns out the service should just depend on the keybindings service as a way to resolve the keybindings for the menu.

@mjbvz mjbvz added the verified Verification succeeded label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants