Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not hardcode border color for monaco-menu-container in HC theme #58496

Closed
bpasero opened this issue Sep 12, 2018 · 2 comments · Fixed by #58568
Closed

Do not hardcode border color for monaco-menu-container in HC theme #58496

bpasero opened this issue Sep 12, 2018 · 2 comments · Fixed by #58568
Assignees
@sbatten
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Milestone
September 2018

Comments

@bpasero
Copy link
Member

bpasero commented Sep 12, 2018 •
edited

It looks like a color sneaked into CSS that should use our theming story instead: https://github.com/Microsoft/vscode/blob/abca8c3ce9c267605efc74d5b79ca2a23e746de1/src/vs/workbench/browser/parts/titlebar/media/titlebarpart.css#L205

We have this color defined (contrastBorder I think).
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug themes Color theme issues accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues workbench-menu labels Sep 12, 2018
@sbatten sbatten added this to the September 2018 milestone Sep 12, 2018
@sbatten
Copy link
Member

sbatten commented Sep 12, 2018

hijacking this issue to fix 5dec587#r30473824 as well

@sbatten sbatten mentioned this issue Sep 13, 2018
Merged
@bpasero
Copy link
Member Author

bpasero commented Sep 13, 2018

@sbatten its a tradeoff, for example in #58498 I decided to leave the default color in the CSS file simply because it would involve quite a bit of code to make that change programmatically. So just see how much pain it would be to remove the CSS color and then decide 👍

@bpasero bpasero added the verified Verification succeeded label Sep 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

Successfully merging a pull request may close this issue.

refactor menu theming to be cleaner and remove css colors sbatten/vscode
2 participants
@bpasero @sbatten