Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a try catch around pty spawn to handle nonexistant file #58912

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Added a try catch around pty spawn to handle nonexistant file #58912

merged 1 commit into from
Sep 19, 2018

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Sep 18, 2018

Fixes #31301

@Tyriar Tyriar added this to the September 2018 milestone Sep 19, 2018
@alexr00 alexr00 merged commit a37adb6 into master Sep 19, 2018
@alexr00 alexr00 deleted the alexr00/exitTerminal branch September 19, 2018 16:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
September 2018
Development

Successfully merging this pull request may close these issues.

Terminals launched with invalid paths hang during creation and never emit onExit
2 participants
@alexr00 @Tyriar