moving TypeScript files in explorer fails to update/prompt imports when containing folder is moved

[dontsave]

• VSCode Version: 1.27.2
• OS Version: Win 10
• Typescript: 3.0.3

Steps to Reproduce:

0. Set update imports on move typescript setting to prompt
1. Create an empty project with 2 typescript files, one importing from the other.
2. In the explorer manually move the depended upon file to a new directory. You will be prompted to update the import. This works fine.
3. Now move that directory into ANOTHER new directory.
4. This time there is no prompt and the import will be broken

[amitnovick]

Found that this issue has bigger impact:

• Also relevant to JavaScript files with javascript.updateImportsOnFileMove.enabled option
• javascript.updateImportsOnFileMove.enabled can be of: {'prompt', 'always'} and fail to update imports in both cases.
• Applies to both Directory Move in Explorer and Directory Rename the same.

Minimal reproduce:

1. Set "javascript.updateImportsOnFileMove": "always" in VSCode settings
2. Set up two files: app.js and lib/components/a.js in the following filesystem hierarchy:

├── app.js
└── lib
    └── components
        └── a.js

3. Insert the following snippets into the files:

// lib/components/a.js
module.exports = 1;

// app.js
const a = require('./lib/components/a.js');

4. Move lib/components directory to components (one hierarchy level up) using the Explorer (drag and drop with mouse):

├── app.js
├── components
│   └── a.js
└── lib

Issue

Expected (app.js import should be updated):

// app.js
const a = require('./components/a.js');

In reality (app.js import was not updated):

// app.js
const a = require('./lib/components/a.js');

Tested on VSCode stable 1.32.3

UPDATE: Bug still present at VSCode stable 1.33.1

[jcalmonte]

Still present in VS Code 1.35.1

[SAkhil95]

Hi All,
@mjbvz
This issue seems fixed now in the latest update 1.40.1

However.. it is not prompting even if I selected prompt.

settings.json shows "javascript.updateImportsOnFileMove.enabled": "prompt" but its behaving as if user selected always.

Having said that, I still believe the current behavior is the correct one as there may be times where user rejects the auto update prompt accidentally which may break the code.

[jonrimmer]

It's not properly fixed. Sometimes moving a folder updates the imports of the TS files inside it. Sometimes it doesn't. There doesn't seem to be any reason for why/when, it's just random. E.g. I can try to move a folder and none of the imports are updated. I reset my git state, try again, and it works. Sometimes even when it does work, broken copies of the original files get left behind in the source directory.

[AveryTheDev]

I am also experiencing this issue still. TypeScript or JS files regardless of whether it is in a folder or not. Auto import enabled in settings

[am4zed]

I am also experiencing what @jonrimmer describes. I moved a folder containing subfolders and files to a new folder and was shown the prompt asking if I'd like to update imports and clicked yes. The folder and its contents were moved the new location but versions of some of the files - identical apart from containing non-updated import paths - were left behind in the original location.

[Danil00524]

I've the same problem. Has somebody done it?

[DustInComp]

Might be caused by the consecutive prompts, one for confirming the Move, one for the import updating.
The second prompt seems to open reliably when you tick "Don't show again" on the first one.

[bartosz-apptimia]

I've got this problem as well. Moving files works well, but moving folders doesn't update the paths.

[alexc777]

I have the same problem, I am working on an ionic project

[SayefReyadh]

For a typescript project faced similar issue from in my end for the following settings,

"javascript.updateImportsOnFileMove.enabled": "always",
"typescript.updateImportsOnFileMove.enabled": "always",

I have changed the settings to promt which seems to solve this issue for now.

"javascript.updateImportsOnFileMove.enabled": "prompt",
"typescript.updateImportsOnFileMove.enabled": "prompt",

My VS Code Version

Version: 1.59.0 (system setup)
Commit: 379476f0e13988d90fab105c5c19e7abc8b1dea8
Date: 2021-08-04T23:13:12.822Z

[nicitaacom]

I have this same issue with this settings:

"typescript.updateImportsOnFileMove.enabled": "always",

For me this settings don't help

"javascript.updateImportsOnFileMove.enabled": "prompt",
"typescript.updateImportsOnFileMove.enabled": "prompt",

665f959d-f30d-46ac-b813-b882dfe5ae88.mp4

I'm expect that import path will be updated once file/files moved to antoher directory