Added special handling of link over tooltip for DOM renderer #59060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Sep 20, 2018
| ) { | ||
| const baseLocalLinkClause = _platform === platform.Platform.Windows ? winLocalLinkClause : unixLocalLinkClause; | ||
| // Append line and column number regex | ||
| this._localLinkPattern = new RegExp(`${baseLocalLinkClause}(${lineAndColumnClause})`); | ||
| this.registerWebLinkHandler(); | ||
| this.registerLocalLinkHandler(); | ||
| this._configHelper = instantiationService.createInstance(TerminalConfigHelper); |
There was a problem hiding this comment.
You'll want to use ITerminalService.configHelper to access this as it's shared between everything.
Tyriar
approved these changes
Sep 21, 2018
alexr00
force-pushed
the
alexr00/domLinkHandling
branch
from
0739e65
to
777e456
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50128