Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notification for automatic import updates. #59151

Closed
ko-dever opened this issue Sep 22, 2018 · 1 comment
Closed

Improve notification for automatic import updates. #59151

ko-dever opened this issue Sep 22, 2018 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality javascript JavaScript support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@ko-dever
Copy link

ko-dever commented Sep 22, 2018

Hello everyone.

I did some researches but it seems this request does not already exist, if so, I am sorry.

This is what we get when we move a file and it is imported into other files :
vscode update imports not clear

But I found this a bit confusing.
Okay the two buttons "No, never..." and "Yes, always..." answer clearly to the question in the notification, but it becomes weird when we see the two other buttons "No" and "Yes".

The first thought I had was "what exactly will happen if I click No or Yes given the initial question ?".

Would not it be simpler to have something like that ?

Update imports that reference this file ?
[ Yes, update those imports ] [ No, don't make any changes ]
[ Always update all imports ] [ Never update imports ]

Thank you.

@vscodebot
Copy link

vscodebot bot commented Sep 22, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the javascript JavaScript support issues label Sep 22, 2018
@mjbvz mjbvz added the feature-request Request for new features or functionality label Sep 24, 2018
@mjbvz mjbvz added this to the October 2018 milestone Oct 5, 2018
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Oct 5, 2018
@mjbvz mjbvz closed this as completed in 03ed095 Oct 5, 2018
@roblourens roblourens added the verified Verification succeeded label Nov 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality javascript JavaScript support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants