Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: layout bug #59217

Closed
warpdesign opened this issue Sep 24, 2018 · 7 comments
Closed

Settings: layout bug #59217

warpdesign opened this issue Sep 24, 2018 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority settings-editor VS Code settings editor issues verified Verification succeeded

Comments

@warpdesign
Copy link
Contributor

  • VSCode Version: 1.28-insider (2558a72)
  • OS Version: OSX 10.12.6

Steps to Reproduce:

  1. Split the editor like in the first screenshot
  2. Open the settings panel

The categories overwrite each setting, making the panel barely readable.

The weird thing is that reducing the Settings tab width fixes the problem, because it's reaching a media query limit I guess.

Does this issue occur when all extensions are disabled?: Yes

First screenshot:

image

Second screenshot (reduced tab width):

image

My screen resolution: 27" 2560x1440 with default OSX scale.

@roblourens
Copy link
Member

roblourens commented Sep 24, 2018

Can you update Insiders and try again? There were some layout changes in the last build and I can't repro.

If so, is it easy to repro or just at a certain width? Do you see it only in search mode or also in non-search mode?

@warpdesign
Copy link
Contributor Author

@roblourens I updated to build fe8d9d2 But there are still bugs:

image

@roblourens
Copy link
Member

roblourens commented Sep 25, 2018

I still can't repro this, can you come up with steps to repro the issue from a clean state?

Or if you can inspect that TOC element in chrome devtools and show me how it's getting over there, that would be very helpful.

@warpdesign
Copy link
Contributor Author

Opening VSCode, splitting it in 3 columns, selecting the middle column and opening preferences is enough to trigger the layer bug.

Here is the inspector on the TOC element:

image

@warpdesign
Copy link
Contributor Author

After more tests it seems it's related to the theme I'm using: this only happens with the Nord theme.

I was pretty sure I had tried with extensions disabled :/

I opened up an issue there: nordtheme/visual-studio-code#101

@roblourens
Copy link
Member

So weird! I can repro with Nord too. I see the issue, tbh, I don't know why it doesn't look that way all the time.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues important Issue identified as high-priority labels Sep 25, 2018
@roblourens roblourens added this to the September 2018 milestone Sep 25, 2018
@warpdesign
Copy link
Contributor Author

That was fast! :)

@mjbvz mjbvz added the verified Verification succeeded label Sep 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants