Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

styles for diff on markdown preview #59289

Merged
merged 2 commits into from
Sep 25, 2018
Merged

styles for diff on markdown preview #59289

merged 2 commits into from
Sep 25, 2018

Conversation

agurod42
Copy link
Contributor

Fixes #59288

agurod42
agurod42 commented Sep 25, 2018
View reviewed changes
src/vs/workbench/parts/webview/electron-browser/webview-pre.js Outdated
@@ -258,6 +258,16 @@
color: var(--vscode-textPreformat-foreground);
}

code span.hljs-addition {
background: var(--vscode-diffEditor-insertedTextBackground, rgba(155, 185, 85, 0.2));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This default color was picked up from here: https://github.com/Microsoft/vscode/blob/d9add550e9315d133484f5497362a830a71da29a/src/vs/platform/theme/common/colorRegistry.ts#L292

agurod42
agurod42 commented Sep 25, 2018
View reviewed changes
src/vs/workbench/parts/webview/electron-browser/webview-pre.js Outdated
}

code span.hljs-deletion {
background: var(--vscode-diffEditor-removedTextBackground, rgba(255, 0, 0, 0.2));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This color was picked up from here:

https://github.com/Microsoft/vscode/blob/d9add550e9315d133484f5497362a830a71da29a/src/vs/platform/theme/common/colorRegistry.ts#L293

@mjbvz mjbvz added this to the September 2018 milestone Sep 25, 2018
mjbvz
mjbvz requested changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. The new css looks good but please move these into the markdown specific css file: /extensions/markdown-language-features/media/highlight.css

@mjbvz mjbvz merged commit 9041e6a into microsoft:master Sep 25, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Sep 25, 2018

Awesome! This change will be in the next vs code insiders build and will go to stable in 1.28

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjbvz mjbvz mjbvz requested changes

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
September 2018
Development

Successfully merging this pull request may close these issues.

Wrong diff colors on markdown preview
2 participants
@agurod42 @mjbvz