-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why the flashing when option change in find widget? #59316
Comments
I don't know why/when this flashing was added but @misolori can decide if we want to remove it. |
We should remove it since it's not a pattern we currently use and the focus state is enough of an indicator. It also appears that @alexandrudima added it a while back with 3357ae8, maybe some context would help decide it. |
I was thinking it was just added this month, is it possible that it's a feature that was just recently enabled? No way it's been like that since Jan 2017! But yeah the search view should match too. |
Thanks @roblourens , it looks like a side effect of these two commits, I'll take a look. |
Seems like a regression than, I suggest to assign it to September |
Adding bug label so this gets verfieid |
Refs: #59265
The find widget does not flash if I change state when I click.
I guess the idea is to draw attention that the state changed, however this just looks bad to me and we do not do this sort of ux in other parts of the product.
IMHO we should remove the flashing and just not treat this case specialy
Also we do not flash in the find widget in the terminal which I think is correct @alexr00
fyi @misolori
The text was updated successfully, but these errors were encountered: