Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in editComment/deleteComment not indicated in UI #59348

Closed
chrmarti opened this issue Sep 25, 2018 · 1 comment
Closed

Error in editComment/deleteComment not indicated in UI #59348

chrmarti opened this issue Sep 25, 2018 · 1 comment
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
September 2018

Comments

@chrmarti
Copy link
Contributor

Issue Type: Bug

Testing #59278

The UI stays:
image

There is no indication the operation failed, it looks like it is still running.

This is with both: Throwing an Error immediately and returning a rejected promise.

VS Code version: Code - Insiders 1.28.0-insider (fe8d9d2, 2018-09-25T07:29:33.175Z)
OS version: Darwin x64 17.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (5.66GB free)
Process Argv --user-data-dir /Users/chrmarti/Development/repos/tmp/user2 --extensions-dir /Users/chrmarti/Development/repos/tmp/ext2
Screen Reader no
VM 33%
Extensions: none
@vscodebot vscodebot bot added the insiders label Sep 25, 2018
@chrmarti
Copy link
Contributor Author

Same with deleteComment.

@chrmarti chrmarti changed the title Error in editComment not indicated in UI Error in editComment/deleteComment not indicated in UI Sep 25, 2018
@chrmarti chrmarti mentioned this issue Sep 25, 2018
Closed
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Sep 25, 2018
@RMacfarlane RMacfarlane added this to the September 2018 milestone Sep 25, 2018
@RMacfarlane RMacfarlane mentioned this issue Sep 26, 2018
Closed
@chrmarti chrmarti added the verified Verification succeeded label Sep 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
2 participants
@RMacfarlane @chrmarti