Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SelectionClipboard contribution in suggestEnabledInput #59390

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Use SelectionClipboard contribution in suggestEnabledInput #59390

merged 1 commit into from
Sep 25, 2018

Conversation

ramya-rao-a
Copy link
Contributor

We need to use the SelectionClipboard contribution in suggestEnabledInput to fix #59028

Since SelectionClipboard uses the clipboard from electron, it lives under electron-browser whereas suggestEnabledInput and the settings editor that uses it live under browser.

This PR moves the above from browser to electron-browser, so that SelectionClipboard can be used in suggestEnabledInput

@ramya-rao-a ramya-rao-a self-assigned this Sep 25, 2018
@ramya-rao-a ramya-rao-a merged commit beebc71 into master Sep 25, 2018
@ramya-rao-a ramya-rao-a deleted the ramyar/selection-clipboard branch September 25, 2018 22:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@ramya-rao-a ramya-rao-a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Middle click selection in extension search doesn't copy text to 2nd clipboard linux
2 participants
@ramya-rao-a @roblourens