"Explorer: Focus $View" commands do not include english label in command palette

[mjbvz]

Testing #58469

Issue Type: Bug

1. Using a different UI language in VS Code, such as de
2. With the npm scripts explorer enabled
3. Try running the Explorer: focus npm script explorer command

Bug
Notice that only the localized description is shown in the command palatte:

Most built-in command include both the localized version as the main title and the english version beneath

VS Code version: Code - Insiders 1.28.0-insider (fe8d9d2, 2018-09-25T07:29:33.175Z)
OS version: Darwin x64 17.7.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (3.22GB free)
Process Argv	--locale=de
Screen Reader	no
VM	22%

[sandy081]

Good catch

[mjbvz]

I believe that the viewDescriptor.name will still be localized in the details text even after this change. Is there a way to use the english view name here?

[sandy081]

@dbaeumer Do I get localized string
https://github.com/Microsoft/vscode/blob/087ee56e75b166850a6a664f176c132b36602293/src/vs/platform/actions/common/actions.ts#L18

if the author has a translated string for name property?

[dbaeumer]

@sandy081 not sure I understand your question.

[jrieken]

Still seeing, no english alternative...

[sandy081]

@dbaeumer View is an extension point with following schema

{ 
    id: string;
	name: string;
	when?: string;
}

If an extension provides a localised string for name like %view.name% and when I am reading the extension point in core, do I receive localised string or a localised string object that has both original and localised value?

[sandy081]

@jrieken I think it is because the german language pack extension is not yet up to date providing the translations for these commands. Only view name is translated because the view is registered with translated string. Once the language pack extension is updated you can see both strings.

[jrieken]

ok